WIP: add lazy loading for dashboard #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukutaht
added a commit
that referenced
this pull request
Mar 31, 2021
* WIP: add lazy loading for dashboard * Improve error handling * WIP * Implement lazy loading for most reports * Add lazy loading to conversions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I noticed that a lot of queries to CH run considerably faster when run in isolation vs when loading the whole dashboard. When loading the dashboard, we fire about 10 separate queries to Clickhouse. I believe all these concurrent queries are competing for CPU and RAM resources.
By loading only the data that is visible in the user's viewport, we can reduce the number of concurrent queries which should free up resources for the queries that are most important (i.e. visible part of the dashboard)
Thanks @Vigasaurus for the work on sticky header. I'm taking the InteractionObserver code as base for the LazyLoader.
Tests
Changelog
Documentation