Allow for Esc to clear all filters
#625
Conversation
|
Nice! Our keyboard shortcuts game is getting stronger! I like it! |
|
I'm actually considering something else too, but I did actually want y'all's feedback/opinions. I don't know that actually showing them here is necessary, but I thought something like this very similar to how calendar apps work could be neat. (This is just a mock up made in paint) The keybinds and the UI are the main things I wanted opinions on. For the Custom I thought it would be cool for it to just open up the Calendar input automatically, and for the others to do what you'd expect (i.e. exactly what clicking the button would do) Google Calendar's implementation: |
|
that's very cool and i was thinking to share that idea. i didn't know it's a google calendar thing but last week we started using Hey for email and they do that everywhere and I really like it (just need to get used to the different keybindings)
showing the keybinding in the UI makes sense to make people aware of it and remember it and i like your implementation! and just using the first letter of what the action is makes sense to me (c for custom etc). if we introduce this, i would add a keyboard shortcuts page to the docs too. |
|
Sounds good (I've always been meaning to try hey but ... lazy)! How do you feel about the following, then? I think some of the more obscure ones don't need a binding, but lmk if you think there should be one for any.
|
|
looks good to me @Vigasaurus! good that it follows google calendar as i assume that may be the standard that's used in more apps too. |
assets/js/dashboard/filters.js
Outdated
| handleKeyup(e) { | ||
| const {query, history} = this.props | ||
|
|
||
| if (e.ctrlKey || e.ctrlKey || e.altKey) return |
There was a problem hiding this comment.
Seems like ctrlKey is checked for twice
There was a problem hiding this comment.
Ah haha - I just copied this from the DatePicker arrows, didn't even notice 🙈
One of them should be metaKey, I believe
* Allow for `Esc` to clear all filters * Changelog * Change duplicated ctrlKey (in DatePicker too)
Changes
Resolves #575
Tests
Changelog
Same as my other PRs heh - lmk what you want for changelog format and I'll get it sorted
Documentation
🤷♂️