Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds list-based country report option #1381

Merged
merged 6 commits into from
Oct 14, 2021

Conversation

Vigasaurus
Copy link
Contributor

@Vigasaurus Vigasaurus commented Oct 8, 2021

Changes

Resolves #1376 as discussed, and sets up for future additional reports in a similar manner for regions/cities

I do think some of the UI strings could be improved/changed, but these are what I came up with

I apologize in advance for all the PR reviews I put on your plate in the past few days Uku 👀

Tests

  • This PR does not require tests

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Screenshots

firefox_2021-10-08_02-35-33
firefox_2021-10-08_02-35-42
image

@metmarkosaric
Copy link
Contributor

looking great! thanks @Vigasaurus!

@Vigasaurus Vigasaurus requested a review from ukutaht October 13, 2021 18:32
@ukutaht ukutaht merged commit 0c982a8 into plausible:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants