Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fixed address 0x10000 for firmware #785

Closed
wants to merge 4 commits into from

Conversation

Jason2866
Copy link
Contributor

@Jason2866 Jason2866 commented Apr 30, 2022

since this prevents to use a factory firmware which should be placed at address 0x10000.
The flash address for the user firmware (ota_0) is read from the partition.csv.
A flash_extra_images as example for useage.
Idk what this part of the code has done before.

@stale
Copy link

stale bot commented Jul 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. Please provide more details or it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 30, 2022
@Jason2866
Copy link
Contributor Author

bump

@stale stale bot removed the stale label Jul 30, 2022
@proddy
Copy link

proddy commented Sep 4, 2022

+1

@Jason2866
Copy link
Contributor Author

Jason2866 commented Oct 4, 2022

@valeros I noticed that setting the env variable here does not work as expected

env["ESP32_APP_OFFSET"] = hex(bound)

It seems it is encapsulated. Is there a way to set it global? The PR does work nice for setting the address (dynamically) for the firmware when flashing with esptool.py but it fails when using the debugger.

EDIT: Solution found and updated.

@Jason2866
Copy link
Contributor Author

Jason2866 commented Oct 7, 2022

Updated and debugger now uses the correct offset too. No need to specify ESP32_APP_OFFSET anywhere since it is read from the partitions.csv

@valeros Can you review? If not considered to be used please tell so i can close.

@stale
Copy link

stale bot commented Nov 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. Please provide more details or it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 9, 2022
@stale stale bot closed this Nov 22, 2022
@Jason2866 Jason2866 deleted the patch-3 branch November 28, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants