Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

These changes are for cloud-ctl error lablels #405

Closed
wants to merge 1 commit into from

Conversation

Sven27
Copy link

@Sven27 Sven27 commented Mar 7, 2025

ISSUE(S):

https://platform9.atlassian.net/browse/PCD-607

SUMMARY

This is related cloud-ctl as the error message should have cloud-ctl rather than pf9ctl so for the ld-flag introduced a variable so the value can be changed dynamically in cloud-ctl and it won't affect pf9ctl as well

ISSUE TYPE

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that may cause existing functionality to not work as expected)
  • This change requires a documentation update

IMPACTED FEATURES/COMPONENTS:

RELATED ISSUE(S):

DEPENDS ON:

TESTING DONE

in progress

Reviewers

Summary by Bito

This PR enhances error message clarity by making them dynamically include tool names and improving configuration-related code. It updates error messages in pkg/config/config.go for missing configurations, introduces a new 'Ctl' constant in pkg/util/constants.go, and refines error messages for version conflicts and sudo privileges using fmt.Sprintf.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 1

Copy link
Contributor

bito-code-review bot commented Mar 7, 2025

Code Review Agent Run #195b94

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: 665a069..665a069
    • pkg/config/config.go
    • pkg/util/constants.go
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at mithil@platform9.com.

Documentation & Help

AI Code Review powered by Bito Logo

Copy link
Contributor

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Bug Fix - Error Message Corrections and Dynamic Configuration

config.go - Reformatted the missing config error to use dynamic formatting and adjusted comment spacing for clarity.

constants.go - Added the 'fmt' import and new 'Ctl' constant, then updated error messages to dynamically insert the tool name for better accuracy.

@Sven27 Sven27 closed this Mar 7, 2025
@Sven27 Sven27 deleted the private/main/tejas/PCD-607 branch March 7, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant