Fix the Go toolchain setup for MacOS #17
Conversation
| @@ -36,9 +40,7 @@ SPRINGBOARD_FULL_TAG := $(SPRINGBOARD_REPO_TAG):$(IMAGE_TAG) | |||
|
|
|||
| DEFAULT_HTTP_IMAGE_TAG ?= platform9systems/decco-default-http | |||
|
|
|||
| export GOPATH:=$(GOPATH_DIR) | |||
There was a problem hiding this comment.
Now that this line is removed, what GOPATH does the build use?
There was a problem hiding this comment.
I was thinking it would use the one already set in the system, since the packages are not Go-version or OS-dependent.
In the kplane repository, we aren't setting it either. See for example: https://github.com/platform9/kplane/pull/47
There was a problem hiding this comment.
Ok, I'll have to make sure the TC builders actually have a sane GOPATH defined, or explicitly define one (perhaps a temporary one) in the TC build step. I'm slightly nervous about multiple builds on the same builder sharing the same GOPATH.
There was a problem hiding this comment.
Go modules supports multiple versions of a dependency to be stored in the same GOPATH. So it should be fine, as long as some GOPATH is provided.
90f60ef to
5eb33f9
Compare
This PR fixes the development setup by ensuring that the correct Go toolchain is downloaded based on OS.
Beyond that it cleans up some unused variables and recipes.