Skip to content

Commit

Permalink
test deferred till vitessio#12147 is merged
Browse files Browse the repository at this point in the history
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
  • Loading branch information
shlomi-noach committed Mar 5, 2023
1 parent e634d29 commit 12df1ce
Showing 1 changed file with 14 additions and 13 deletions.
27 changes: 14 additions & 13 deletions go/vt/schemadiff/schema_diff_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -257,18 +257,19 @@ func TestSchemaDiff(t *testing.T) {
expectDeps: 1,
entityOrder: []string{"t2", "v2"},
},
{
name: "alter view (2 tables), alter tables",
toQueries: []string{
"create table t1 (id int primary key, info int not null, dt datetime);",
"create table t2 (id int primary key, ts timestamp, v varchar);",
"create view v1 as select id from t1",
"create view v2 as select info, v from t1, t2",
},
expectDiffs: 3,
expectDeps: 2,
entityOrder: []string{"t1", "t2", "v2"},
},
// {
// // This will become relevant when https://github.com/vitessio/vitess/pull/12147 is merged
// name: "alter view (2 tables), alter tables",
// toQueries: []string{
// "create table t1 (id int primary key, info int not null, dt datetime);",
// "create table t2 (id int primary key, ts timestamp, v varchar);",
// "create view v1 as select id from t1",
// "create view v2 as select info, v from t1, t2",
// },
// expectDiffs: 3,
// expectDeps: 2,
// entityOrder: []string{"t1", "t2", "v2"},
// },
{
name: "drop view",
toQueries: []string{
Expand Down Expand Up @@ -354,7 +355,7 @@ func TestSchemaDiff(t *testing.T) {
entityOrder: []string{"t2", "v1", "v2"},
},
// {
// // This will become relevant when https://github.com/vitessio/vitess/issues/12147 is merged
// // This will become relevant when https://github.com/vitessio/vitess/pull/12147 is merged
// name: "alter table, alter view, impossible sequence",
// fromQueries: []string{
// "create table t1 (id int primary key, info int not null);",
Expand Down

0 comments on commit 12df1ce

Please sign in to comment.