Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect config.url as source of truth for API calls #138

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

iheanyi
Copy link
Member

@iheanyi iheanyi commented Aug 21, 2023

This pull request updates our driver to use config.url as the source of truth for the base URL of our API calls. The way this was set up before, we could only make these calls to the production API. Some users have been mocking out the Edge API locally, so this gives users a means of working with Edge locally without needing to introduce an insecure flag into the driver.

Closes #136 #135

iheanyi and others added 2 commits August 21, 2023 13:19
…r protocols

Co-authored-by: David Graham <dgraham@github.com>
Co-authored-by: David Graham <dgraham@github.com>
Copy link
Member

@dgraham dgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️

@iheanyi iheanyi merged commit 0c3dea9 into main Aug 21, 2023
@iheanyi iheanyi deleted the iheanyi/allow-http-urls branch August 21, 2023 18:25
sebald referenced this pull request in sebald/pattern-analyzer Sep 11, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@planetscale/database](https://togithub.com/planetscale/database-js)
| [`1.10.0` ->
`1.11.0`](https://renovatebot.com/diffs/npm/@planetscale%2fdatabase/1.10.0/1.11.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@planetscale%2fdatabase/1.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@planetscale%2fdatabase/1.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@planetscale%2fdatabase/1.10.0/1.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@planetscale%2fdatabase/1.10.0/1.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>planetscale/database-js
(@&#8203;planetscale/database)</summary>

###
[`v1.11.0`](https://togithub.com/planetscale/database-js/releases/tag/v1.11.0)

[Compare
Source](https://togithub.com/planetscale/database-js/compare/v1.10.0...v1.11.0)

#### What's Changed

- Add usage instructions with boost by
[@&#8203;mscoutermarsh](https://togithub.com/mscoutermarsh) in
[https://github.com/planetscale/database-js/pull/130](https://togithub.com/planetscale/database-js/pull/130)
- Respect `config.url` as source of truth for API calls by
[@&#8203;iheanyi](https://togithub.com/iheanyi) in
[https://github.com/planetscale/database-js/pull/138](https://togithub.com/planetscale/database-js/pull/138)

#### New Contributors

- [@&#8203;mscoutermarsh](https://togithub.com/mscoutermarsh) made their
first contribution in
[https://github.com/planetscale/database-js/pull/130](https://togithub.com/planetscale/database-js/pull/130)

**Full Changelog**:
planetscale/database-js@v1.10.0...v1.11.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/sebald/pattern-analyzer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants