Introduce seasonpass api #2418
Open
Introduce seasonpass api #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ipdae
commented
Feb 19, 2025
- 시즌패스 api 서버를 eks 로 이전합니다.
|
sky1045
reviewed
Feb 19, 2025
| @@ -58,6 +58,9 @@ gateway: | |||
| hostnames: | |||
| - thor-internal-arena.9c.gg | |||
| - thor-preview-arena.9c.gg | |||
| - name: seasonpass-api | |||
| hostnames: | |||
| - season-pass-internal.9cc.gg | |||
| @@ -0,0 +1,112 @@ | |||
| {{- if $.Values.seasonpass.enabled }} | |||
There was a problem hiding this comment.
여긴 $.Values.seasonpass.api 이거 안쓰나요
Comment on lines
2
to
10
| apiVersion: v1 | ||
| kind: ServiceAccount | ||
| metadata: | ||
| annotations: | ||
| eks.amazonaws.com/role-arn: {{ .Values.seasonpass.serviceAccount.roleArn }} | ||
| labels: | ||
| app.kubernetes.io/instance: {{ $.Release.Name }} | ||
| name: {{ $.Release.Name }}-seasonpass-iam-role | ||
| namespace: {{ $.Release.Name }} |
There was a problem hiding this comment.
서비스어카운트는 이미 트래커쪽에서 만드니까 여기선 빼주시는게 좋겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.