Add NSFW warning infobox on first visit #1851
Conversation
Fixes #1450 Add a warning infobox for NSFW content when first visiting the Atlas. * Modify `web/index.html` to include a modal warning infobox about NSFW content that appears on the first visit, with a general disclaimer and a tickbox to accept the warning. * Change `web/_js/main/main.js` to add functions for checking if the user has previously dismissed the NSFW warning, showing the NSFW warning infobox, and preventing loading the data until the popup has been accepted. * Modify `web/_js/config.js` to add a configuration option for displaying the NSFW warning infobox. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/placeAtlas/atlas-2023/issues/1450?shareId=XXXX-XXXX-XXXX-XXXX).
✅ Deploy Preview for place-atlas-2023 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
There was a problem hiding this comment.
I prefer having the modal (not to be confused as an infobox) as the general disclaimer as I stated on #1450 (comment).
PS. ai generated aah pr body 💀
|
@Hans5958 Could you explain? I assume you are referring to the nsfw warning at the top. Do you mean it should be seperate or what exactly? |
|
Should this section be changed?
This sounds better:
|
What I'm saying that the modal should contain general disclaimer about the content, not just NSFW. This is what I explained on #1450 earlier. My expectation is that the contents of the modal (which you defined with an ID called
EDIT: Oh, I just realised that you included the disclaimer. If that's the case, what I meant is that I want that disclaimer as the main thing instead, and the NSFW warning is included inside the disclaimer. PS. The bullet points on #1450 is just notes. I expect that to be expanded to have a formal language, like what I did on the example above. |
|
OHHHHH, I see, thanks. |
|
Note: It checks the domain now, so you only get the warning on the prod domain |
| const disclaimerConfig = { | ||
| showWarning: true | ||
| }; | ||
| window.disclaimerConfig = disclaimerConfig; | ||
|
|
There was a problem hiding this comment.
Again, move this to main.js because this file is for instance configuration.
| <div class="modal-dialog modal-dialog-centered"> | ||
| <div class="modal-content"> | ||
| <div class="modal-header"> | ||
| <h5 class="modal-title" id="disclaimerModalLabel">Place Atlas disclaimer</h5> |
There was a problem hiding this comment.
Either I would have "Atlas disclamer" or just "Disclaimer". I prefer just "Disclaimer", but if you prefer the long one, make sure to use "r/place Atlas Disclaimer" (note the "r/place)
Fixes #1450
Add a warning infobox for NSFW content when first visiting the Atlas.
web/index.htmlto include a modal warning infobox about NSFW content that appears on the first visit, with a general disclaimer and a tickbox to accept the warning.web/_js/main/main.jsto add functions for checking if the user has previously dismissed the NSFW warning, showing the NSFW warning infobox, and preventing loading the data until the popup has been accepted.web/_js/config.jsto add a configuration option for displaying the NSFW warning infobox.For more details, open the Copilot Workspace session.