Request for new OP DOI RA plugin in the gallery

[njikonga-med]

Hello @asmecher or @bozana, This is request to include a new plugin to the gallery for the DOI registration agency Open Publications.
All the required information have been provided in the snippet. Please could you please verify and let me know?

With regards,
Jehu Njikonga

[bozana]

Hi @njikonga-med, I will take a look at the plugin and will then let you know...
(In the meantime: is the change of the .gitignore here by accident or wanted?)
Thanks a lot!

[njikonga-med]

Hi @njikonga-med, I will take a look at the plugin and will then let you know... (In the meantime: is the change of the .gitignore here by accident or wanted?) Thanks a lot!

Hi @bozana , the change of the .gitignore is not there accidently, it's because I opened the project with Eclipse and automatically, it creates the .project, and that is the reason. Maybe there is no need of putting it inside the .gitignore?

Thanks,
Jehu Njikonga

[njikonga-med]

Hi @bozana , hope this short message find you well. Waiting for the snippet approval of OP DOI RA new plugin in the gallery. Any news?

With regards,
Jehu Njikonga

[bozana]

HI @njikonga-med, I need to review the plugin, but I (we all) are so busy with the coming 3.5 that I will need a little bit more time for this. I will get to it as soon as possible, I hope this week. Sorry for the delay and thanks for understanding.

[njikonga-med]

Ok. thanks.

[bozana]

Hi @njikonga-med,
Sorry for the delay. I first now managed to take a look at the plugin. I would have a few comments:

• OPdoiraDoiDataMigration.php is not needed, also the function OPdoiraPlugin::preInstall() and the hook Hook::add('Installer::preInstall', [$this, 'preInstall']); in function OPdoiraPlugin::register() -- this class and function are for users that come and upgrade from OJS 3.3 to OJS 3.4, where DOIs were significantly changed and needed to be moved into different tables.
• You probably do not need the folder tests/, if you do not want to write and maintain the tests. Also in this folder medra occurs in few places:
  In OPdoiraWebserviceTest.php there is use APP\plugins\generic\medra\classes\OPdoiraWebservice;.
  In serial-article-as-work.xml and serial-issue-as-work.xml there is medra in schemaLocation, ToCompany and RegistrationAuthority.
• In OPdoiraWebservice: medra is in SOAP-ENV and in attachment and soapMessage id. Maybe this is OK so?
• In ArticleOPdoiraXmlFilter::appendCitationListNodes(): $opdoiraCitationNamespace contains medra. Maybe this is OK so?

Have you managed also to test the plugin and register the DOIs?

Thanks a lot!

[njikonga-med]

Hi @bozana , thanks for the time spent to check the new plugin so it may meet the OJS requirements standard. I tried to apply all the changes you suggested in the former post:

• Instead of remove the class OPdoiraDoiDataMigration.php, I commented all the whole content, and comment also the function OPdoiraPlugin::preInstall() and the hook Hook::add('Installer::preInstall', [$this, 'preInstall']); in function OPdoiraPlugin::register(), this could be suitable?
• I suggest to keep it, it could be useful for further implementation. I also correct the ToCompany and RegistrationAuthority in the xml file test serial-article-as-work.xml and serial-issue-as-work.xml. I also correct the SchemaLocation, by putting the new ONIX schema for the new Client
• In OPdoiraWebservice: the medra in SOAP-ENV and attachment are correct, but I modified the soapMessage id that's generated by the following function _getContentId(string $prefix): string in the same class
• In ArticleOPdoiraXmlFilter::appendCitationListNodes(): , the $opdoiraCitationNamespace contains medra, it's correct.

I confirmed that I installed the new plugin in a new OJS 3.4 and made some successfully test

Thanks again and let me know.

[bozana]

Hi @njikonga-med,
one more thing:
I see you have (in OPdoiraExportDeployment.php):
http://ra.publications.europa.eu/schema/onix/DOIMetadata/2.0/ONIX_DOIMetadata_2.0.xsd
and
http://ra-publications-dev.medra.org/schema/onix/DOIMetadata/2.0/ONIX_DOIMetadata_2.0.xsd

I suppose for production and testing?
in filterConfig.xml however you have the http://ra-publications-dev.medra.org/schema/onix/DOIMetadata/2.0/ONIX_DOIMetadata_2.0.xsd that I would think is the schema for testing, but in filterConfig.xml should be the one from production.
It that all correct?

Once that is solved, you can create a new release e.g. 1.0.0.1 and adapt the plugins.xml here to point to that release.

Also, you can remove .projects from .gitignore -- this can then stay locally just for you...

Thanks!

[njikonga-med]

Hi @bozana ,
I corrected the filterConfig.xml by putting the correct production schema location http://ra.publications.europa.eu/schema/onix/DOIMetadata/2.0/ONIX_DOIMetadata_2.0.xsd in place of the testing one.

As soon as possible, I will adapated the snippet of plugins.xml in the gallery for the new OP DOI RA Plugin.

Thanks.

[njikonga-med]

Dear @bozana,

I just created the new snippet in plugin gallery. Could you please verify the whole process and let us known?
Thanks.

Jehu Njikonga

[bozana]

Hi @njikonga-med, all fine. If you could just remove that .gitignore from this PR, then I can merge...

[njikonga-med]

Hi @bozana , I removed from the .gitignore the .project.
I have one more question: If we suppose that an OJS OP client have always register Journal with OJS 3.3 and what to install the new plugin OP DOI RA, he must first upgrade to OJS 3.4 and then install the plugin, it's right?

With regards,
Jehu Njikonga