Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#9658 changes in invitation and user access table #10895

Merged
merged 1 commit into from
Feb 25, 2025
Merged

pkp/pkp-lib#9658 changes in invitation and user access table #10895

merged 1 commit into from
Feb 25, 2025

Conversation

ipula
Copy link
Contributor

@ipula ipula commented Feb 6, 2025 •
edited
Loading

see #10916

@withanage withanage mentioned this pull request Feb 6, 2025
Open
@ipula ipula force-pushed the ipula/9658-changes branch from d4dc2b0 to 58eba87 Compare February 12, 2025 13:12
blesildaramirez
blesildaramirez reviewed Feb 17, 2025
View reviewed changes
@ewhanson ewhanson self-requested a review February 19, 2025 16:58
ewhanson
ewhanson requested changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@ewhanson ewhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ipula! Looking really good, just a few questions and small corrections.

@ipula ipula force-pushed the ipula/9658-changes branch from 2573bc9 to 55b53bc Compare February 20, 2025 10:15
@withanage withanage mentioned this pull request Feb 20, 2025
Open
@ipula ipula requested a review from ewhanson February 20, 2025 13:11
ewhanson
ewhanson requested changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@ewhanson ewhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ipula, just one additional reference to OJS I found, but otherwise looks good!

@ipula ipula requested a review from ewhanson February 21, 2025 18:43
@withanage
Copy link
Member

@ewhanson if you can confirm this , we can mark this as resolved for merging.

ewhanson
ewhanson approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@ewhanson ewhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @ipula. It just needs to be squashed into a single commit then it's ready for merge. cc: @withanage.

@withanage
Copy link
Member

Thanks @ewhanson for reviewing, tomorrow we will merge after squashing the commits to one

@ipula ipula force-pushed the ipula/9658-changes branch from efa2618 to c2f9b5e Compare February 25, 2025 11:34
@withanage withanage merged commit aff4585 into pkp:main Feb 25, 2025
2 checks passed
@asmecher asmecher mentioned this pull request Feb 28, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blesildaramirez blesildaramirez blesildaramirez left review comments

@ewhanson ewhanson ewhanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ipula @withanage @blesildaramirez @ewhanson