Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewer shown as "never assigned" when they have active review assignments #4312

Closed
NateWr opened this issue Dec 19, 2018 · 6 comments
Closed
Assignees
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. Hosting Bug reports and feature requests from Publishing Services's hosted clients.
Milestone

Comments

@NateWr
Copy link
Contributor

NateWr commented Dec 19, 2018

Describe the bug
A reviewer may be shown as "never assigned" when they have active review assignments. This occurs when a reviewer's first invitation was on the same day.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a submission in the review stage.
  2. Click on Add Reviewer
  3. Create a new reviewer and assign them.
  4. Go to another submission in the review stage.
  5. Find the new reviewer and see they are "never assigned", even though they've just been assigned.

What application are you using?
OJS 3.3.0-x

Additional information
From @openacademia, #4246 (comment):

Sidenote: the current messages in the selection list is a little confusing. It says "Never assigned" when in fact a reviewer has active reviews, see screenshot.

50173380-8e5abe00-02f7-11e9-8dff-57ea9d51f51f

@openacademia, can you confirm whether the active reviews were assigned on the same day? Looking at the code, that's my best guess.

@openacademia
Copy link

@NateWr aaaah, yes, you are right. They were invited earlier that same day. I checked again now and the message is now relevant; instead of Never Assigned it now says Yesterday.
It might still be a little confusing for editors who tend to invite reviewers for several manuscripts on the same day (whenever they can carve out some time to do editor work!), but it is not a huge problem then. =)

@NateWr
Copy link
Contributor Author

NateWr commented Dec 19, 2018

Still a bug we want to solve, just confirming the source of it. 👍

@NateWr NateWr added Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. Hosting Bug reports and feature requests from Publishing Services's hosted clients. labels Apr 8, 2019
@librariam
Copy link
Collaborator

+1 from PKP|PS. Also the case with reviewers assigned on the same day.

@juliaflanders
Copy link

juliaflanders commented Apr 30, 2022

I have experienced this problem as well (see https://forum.pkp.sfu.ca/t/days-since-last-review-errors-in-ojs/72558) but it affects all reviewers, not just those recently assigned. When I view the list of reviewers, all of them show as "never assigned" whereas my colleague viewing the same list sees actual review assignments (and they vary widely in date--not just recent assignments). Not sure whether this is the same bug or a related one.

@NateWr
Copy link
Contributor Author

NateWr commented May 2, 2022

No, I don't think that it is the same issue.

@eczheng
Copy link

eczheng commented Nov 16, 2023

+1 one of our journals has also observed this bug.

asmecher added a commit to pkp/ui-library that referenced this issue Nov 17, 2023
asmecher added a commit to pkp/ui-library that referenced this issue Nov 17, 2023
asmecher added a commit to pkp/ui-library that referenced this issue Nov 17, 2023
@asmecher asmecher added this to the 3.3.0-16 milestone Nov 17, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Peer Review Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. Hosting Bug reports and feature requests from Publishing Services's hosted clients.
Projects
Status: Done
Development

No branches or pull requests

7 participants