Redesigned Workflow - Permissions

[jardakotesovec]

Most permission related logic is mentioned and tested in individual tickets for given area. This is just to cover any outstanding scenario(s) and some exploratory testing if we might have missed something...

Not having access to the stage

• this is controlled via Users & Roles -> Roles by selecting relevant stages

[Tribunal33]

@jardakotesovec Looking at the OPS user roles setting doens't seem to have defined stages applied to the role. Are there any stages that a user shouldn't be able to view for OPS?

[Tribunal33]

@jardakotesovec also can I get some clarification with this. I created a user with the role Production editor which should only have access to copyedit and production stage as defined in the settings. However, I can view the submissions in reivew or submission stages and I can access the particular submission in that stage. Shouldn't I not be allowed this?

[Tribunal33]

@jardakotesovec Additionally. When I logged in as a copyeditor (mfritz) for example on 3.4 I don't have access to the publication tab nor when I try to access different stages will it allow me to see anything extra the stage's page is blank and a warning popup message shows up.

But for 3.5 when I'm using a copyeditor (mfritz) I have access to side buttons and the publication tab.

[Tribunal33]

One more for when logged in as a Production editor. They have access to create a new submission but do not have access to create the article type on the 2nd step. I don't know if this falls under this GitHub ticket but it was during exploratory testing.

[jardakotesovec]

1. regarding OPS - not sure if I fully understand the question. I think good way to think about it that OPS has only production stage. Therefore there are only Production related permissions, which I would expect to work same as in OJS. But its probably good to do some testing around it as I am not 100% sure about that.

2. Production Editor - The logic for permissions is that if you are not assigned to submission and you are Journal Manager - thats the permission you got for all stages. If you are assigned to the submission than the permission role of that assignment is used. Therefore assigned Production Editor can access only editorial and production stage, while unassigned can access everything. And this behaviour seems to be consistent with 3.4. So lets discuss with the team whether we want to change this behaviour - but I would consider it as out of the scope for this one.

3. Publication tab - logic for publication tab is basically that if user has access to currently active stage - he can also see the publication tab. Interestingly author can see publication tab always. I missed that and will make the adjustment.

4. Hiding everything when not having access to stage - good catch, I will make adjustment to also hide actions/secondary items when user does not have access to the stage.

5. Create submission as publication editor - good observation - but for that one I would suggest to check also 3.4 and fill separate bug report as it seems more relevant to submission wizard rather than dashboard/workflow areas.

[Tribunal33]

1. I think I understand better now. There might be some issues with the new role Editoral Board Manager with permission level assistant for OPS but I think out of scope for here.
2. Working as intended
3. Resolved
4. Resolved
5. Created new bug out of scope with this ticket [Create Submission] | Upload Files - Production editor adding a file and updating article text receives an access denied 401 error #10929

[Tribunal33]

Test Case Overview

1. Test stage access for OJS, Select all stages for each role.
   a. Test Admin (full access to all stages)
   b. Test Journal Manager (full access to all stages)
   c. Test Journal Editor (full access to all stages)
   d. Test Copyeditor (only access to copyediting stage)
   e. Test Proofreader (only access to production stage submissions)
   f. Test Reviewer (only access to review stage)
   g. Test Funder Coordinator (Submission and Review stage access)
2. Test stage access for OMP, Select all stages for each role.
   a. Test Admin (full access to all stages)
   b. Test Press editor (full access to all stages)
   c. Test Copyeditor (only access to copyediting stage)
   d. Test Designer (Only access to production stage)
   e. Test Proofreader (only access to production stage submissions)
   f. Test Internal Reviewer (only access to internal review stage)
   g. Test External Reviewer (only access to external review stage)
   h. Test Funder Coordinator (Submission and Review stage access)
3. Test Stage Access for OPS, Select all stages for each role
   a. Test Admin (Full access to production stage)
   b. Test Preprint Server Manager (Full Access to Production stage)
   c. Test Moderator (Access to Production stage)
   d. Test Author (Production access and Preprint view)
   e. Test Reader (Reader view only can see latest preprints on Table of Contents)
   f. Editorial Board Member (can’t do anything but look)