Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canLoginAs & canMergeUsers to /users endpoint #10637

Closed
jardakotesovec opened this issue Nov 26, 2024 · 3 comments
Closed

Add canLoginAs & canMergeUsers to /users endpoint #10637

jardakotesovec opened this issue Nov 26, 2024 · 3 comments
Assignees
Labels
Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks.
Milestone

Comments

@jardakotesovec
Copy link
Contributor

Describe the issue

User table is being migrated to the Vue.js, relying on the /users endpoint to list the users.

Its not possible to calculate more complex permissions on client side, therefore adding that to the API similarly to #10290 is probably reasonable solution.

LoginAs

LoginAs reference implementation: https://github.com/pkp/pkp-lib/blob/main/controllers/grid/settings/user/UserGridRow.php#L176

Merge users

Merge user reference implementation: https://github.com/pkp/pkp-lib/blob/main/controllers/grid/settings/user/UserGridRow.php#L198

Performance considerations

If its not feasible to optimise the current calculation, that requires multiple sql queries per user - we would want to hide it behind include query param to not affect other use cases for /users endpoint. Otherwise it could be included by default

What application are you using?
OJS, OMP or OPS version 3.5

@Hafsa-Naeem
Copy link
Contributor

@asmecher
Copy link
Member

asmecher commented Dec 6, 2024

Moving this to the 3.5.0 Internal milestone, as it's not a new feature for 3.5 and shouldn't go in the new features list.

@Hafsa-Naeem
Copy link
Contributor

This issue was addressed in the PR for issue #10290, which is already merged. Closing as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks.
Projects
None yet
Development

No branches or pull requests

3 participants