pkp/pkp-lib#4787 Reviewer suggestions #1835
Conversation
543f711 to
10cf70d
Compare
There was a problem hiding this comment.
Thanks @touhidurabir, no comments here. Just a common comment that you will find on OJS.
62462f9 to
b3f0129
Compare
locale/en/default.po
Outdated
|
|
||
| msgid "default.submission.step.reviewerSuggestions" | ||
| msgstr "" | ||
| "<p>When submitting your article, you have the option to suggest 2/3 potential " |
There was a problem hiding this comment.
Here the wording is different than the one in OJS. Is this intentional?
There was a problem hiding this comment.
Right , I missed that . Also wondering if we should centralise in pkp-lib which seems better . One question , instead of article which is OJS specific , what can be used as common word for both OJS and OMP ? like instead of When submitting your article should we say When submitting your submission ? I am not sure about the common term .
There was a problem hiding this comment.
submitting your submission doesn’t sound quite right to me, but I’m not the best person to determine the most suitable term or wording.
For now, I suggest keeping it context-specific: using article for OJS and monograph for OMP. We can revisit this later if a more unified term becomes necessary.
There was a problem hiding this comment.
If we don't need to fork locale keys into 3 places, it's much better :)
I think `When submitting, you have the option..." is just as clear and doesn't require app-specific terminology.
26bd4bc to
6a429b7
Compare
d374160 to
a03f74c
Compare
pkp/pkp-lib#4787 Submodule Update ##touhidurabir/i4787_main##
a03f74c to
b9d04da
Compare
|
Manually merged to resolve submodule conflict. |
for pkp/pkp-lib#4787