Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move variants added to Deno.build.os on v1.31.0 #406

Merged
merged 2 commits into from
Feb 28, 2023
Merged

move variants added to Deno.build.os on v1.31.0 #406

merged 2 commits into from
Feb 28, 2023

Conversation

jhheider
Copy link
Contributor

@jhheider jhheider commented Feb 26, 2023 •
edited
Loading

denoland/deno#17340

fixes #405

  • add additional variants to two cases that switch Deno.build.os
  • bump req to deno.land^1.31.0
  • fix expected return code in unit test

@jhheider jhheider requested a review from mxcl February 26, 2023 23:23
@what-the-diff
Copy link

what-the-diff bot commented Feb 26, 2023 •
edited
Loading

  • Added a default case to the host() function in index.ts
  • Changed os variable from Deno.build to platform, and added logic for unsupported OSs

@jhheider jhheider force-pushed the fix-build.os-union-switches branch from af3f37b to 0f2e4a2 Compare February 26, 2023 23:57
@jhheider jhheider changed the base branch from main to 0.25 February 26, 2023 23:58
@jhheider
Copy link
Contributor Author

jhheider commented Feb 26, 2023 •
edited
Loading

Welp, I managed to merge a PR (0.25) unintentionally. But I've reverted and recreated (annoying). This should be where we should have been.

@jhheider jhheider force-pushed the fix-build.os-union-switches branch from 0f2e4a2 to 2cb9b26 Compare February 27, 2023 00:00
@jhheider jhheider changed the base branch from 0.25 to main February 27, 2023 00:01
@jhheider jhheider force-pushed the fix-build.os-union-switches branch from 2cb9b26 to 1e2922f Compare February 27, 2023 16:37
This was referenced Feb 27, 2023
Closed
Merged
@mxcl
Copy link
Member

mxcl commented Feb 28, 2023

I'd rather a choice that won’t break next time they add more variants.

@mxcl mxcl force-pushed the fix-build.os-union-switches branch from 1e2922f to e008ee6 Compare February 28, 2023 12:39
@mxcl
Copy link
Member

mxcl commented Feb 28, 2023

Welp, I managed to merge a PR (0.25) unintentionally. But I've reverted and recreated (annoying). This should be where we should have been.

We've all done it

@mxcl mxcl merged commit cb14ac0 into main Feb 28, 2023
@mxcl mxcl deleted the fix-build.os-union-switches branch February 28, 2023 12:48
mxcl added a commit that referenced this pull request Feb 28, 2023
@jhheider @mxcl
move variants added to Deno.build.os on v1.31.0 (#406)
4f33358 
* move variants added to Deno.build.os on v1.31.0

denoland/deno#17340

fixes #405

* Don’t break in future when deno add platforms

---------

Co-authored-by: Max Howell <mxcl@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxcl mxcl mxcl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install Error
2 participants
@jhheider @mxcl