unicode * is toxic #4049
Merged
unicode * is toxic #4049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
failure is because LDFLAGS hasn't got our rpath in it. this is odd because we forcibly insert it with our cc shims |
|
explicit gcc means no shims, right? |
|
ohhh, right. rpath. grr. |
|
good error: |
70013f1 to
874e524
Compare
mxcl
commented
Nov 15, 2023
projects/postgresql.org/package.yml
Outdated
| - -headerpad_max_install_names | ||
| linux/x86-64: | ||
| CFLAGS: | ||
| - -fPIC |
mxcl
commented
Nov 15, 2023
projects/postgresql.org/package.yml
Outdated
| @@ -40,8 +40,18 @@ build: | |||
| - --with-lz4 | |||
| - --with-libxml | |||
| - --with-libxslt | |||
| LDFLAGS: | |||
| - -Wl,-rpath,{{pkgx.prefix}} | |||
874e524 to
46ec9fb
Compare
|
nice tricks. No clue how you figured that out! |
|
it's always some set of the same tricks. i think tools get confused calling clang as gcc. though no one should. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.