Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow search for versions directly on npmjs api #240

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

diegoholiveira
Copy link
Contributor

After a small discussion on pkgxdev/pantry#4554, I made this PR to allow us to be able to define packages versions as:

versions:
  npm: nx
  ignore: ["9999.0.1", "999.9.9"]

This will search for versions directly on the NPM Registry API.

I do think this is as much pleasant as fetching versions from github and less prone to errors parsing from HTML with url.

@jhheider
Copy link
Contributor

This is a good idea.

Copy link
Contributor

@jhheider jhheider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good; careful about adding a lot of formatting changes (especially if it doesn't match existing formats, as it makes the diff noisier.

@jhheider jhheider requested a review from mxcl December 23, 2023 23:02
@diegoholiveira
Copy link
Contributor Author

this looks good; careful about adding a lot of formatting changes (especially if it doesn't match existing formats, as it makes the diff noisier.

You're right, I revert those changes introduced by prettier (my code editor is configured to run it after save). The diff is much more clear now.

@mxcl mxcl merged commit 78d40a4 into pkgxdev:main Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants