Code

Encoding SSH filexfer#430

Code

Merged

drakkan merged 44 commits intomasterpkg/sftp:masterfrom refactor/encoding-ssh-filexferpkg/sftp:refactor/encoding-ssh-filexferCopy head branch name to clipboardApr 20, 2021

+4,739

Commits

Commits on Mar 18, 2021

• encoding: import constants

  puellanivis

  committed
  d634c3b

  Copy full SHA for d634c3b

• encoding: Buffer, the workhorse of encoding/decoding

  puellanivis

  committed
  1d8c49a

  Copy full SHA for 1d8c49a

• encoding: ExtensionPair

  puellanivis

  committed
  a150663

  Copy full SHA for a150663

• encoding: raw packets

  puellanivis

  committed
  08fd102

  Copy full SHA for 08fd102

• encoding: InitPacket and VersionPacket

  puellanivis

  committed
  3b0e4a5

  Copy full SHA for 3b0e4a5

• encoding: OpenPacket, Attributes, ExtendedAttribute

  puellanivis

  committed
  b397b70

  Copy full SHA for b397b70

• encoding: don't accumulate packet length size, just use the length at the end

  puellanivis

  committed
  e04f1c6

  Copy full SHA for e04f1c6

• document where Link/Block/Unblock come from

  puellanivis

  committed
  fae73f8

  Copy full SHA for fae73f8

• encoding: move RequestID unmarshalling into UnmarshalBinary from UnmarshalPacketBody

  puellanivis

  committed
  0daa57a

  Copy full SHA for 0daa57a

• encoding: Close Read Write Fstat Fsetstat Readdir

  puellanivis

  committed
  f40e0a8

  Copy full SHA for f40e0a8

• encoding: Opendir

  puellanivis

  committed
  261431e

  Copy full SHA for 261431e

Commits on Mar 19, 2021

• encoding: open_packet → open_packets ahead of Opendir

  puellanivis

  committed
  41ee63f

  Copy full SHA for 41ee63f

• encoding: tests: switch wanted byte slice to use actual value rather than name

  puellanivis

  committed
  e315793

  Copy full SHA for e315793

• encoding: oops fix inconsistencies

  puellanivis

  committed
  65072e2

  Copy full SHA for 65072e2

• encoding: Lstat Setstat Remove Mkdir Rmdir Realpath Stat Rename Readlink Symlink

  puellanivis

  committed
  9ac5730

  Copy full SHA for 9ac5730

• encoding: fix inconsistency, separate generic packet field encoding from argument encoding

  puellanivis

  committed
  051d8eb

  Copy full SHA for 051d8eb

• encoding: test Attributes, consistent test permissions value

  puellanivis

  committed
  f4a91c3

  Copy full SHA for f4a91c3

• encoding: fix unnecessary t.Fatal calls when t.Error is more appropriate

  puellanivis

  committed
  9e7db20

  Copy full SHA for 9e7db20

• encoding: bool type is used in filexfer-06 and later but not explicitly stated as a type

  puellanivis

  committed
  aee41c3

  Copy full SHA for aee41c3

• encoding: NameEntry for SSH_FXP_NAME

  puellanivis

  committed
  9fb09e2

  Copy full SHA for 9fb09e2

• encoding: Status Handle Data Name Attrs

  puellanivis

  committed
  7d03efe

  Copy full SHA for 7d03efe

• encoding: have Buffer implement BinaryMarshaler and BinaryUnmarshaler

  puellanivis

  committed
  d9b8552

  Copy full SHA for d9b8552

• encoding: Extended ExtendedReply

  puellanivis

  committed
  91d2971

  Copy full SHA for 91d2971

• encoding: refactor and cleanup

  puellanivis

  committed
  c92cedf

  Copy full SHA for c92cedf

Commits on Mar 21, 2021

• encoding: refactor buffer slightly

  puellanivis

  committed
  1d3c516

  Copy full SHA for 1d3c516

• encoding: refactor to remove common RequestID from packets

  puellanivis

  committed
  43e9761

  Copy full SHA for 43e9761

• encoding: move raw_packet to packets

  puellanivis

  committed
  62a3f68

  Copy full SHA for 62a3f68

• encoding: RequestPacket type to simplify server implementations

  puellanivis

  committed
  963c7ad

  Copy full SHA for 963c7ad

• enocoding: refactor extended packets

  puellanivis

  committed
  4c0c5ec

  Copy full SHA for 4c0c5ec

• encoding: define our own FileMode conforming to spec

  puellanivis

  committed
  7e701b5

  Copy full SHA for 7e701b5

• encoding: golint

  puellanivis

  committed
  9019ffc

  Copy full SHA for 9019ffc

• encoding: add openssh extended types

  puellanivis

  committed
  e040f49

  Copy full SHA for e040f49

Commits on Mar 22, 2021

• encoding: address documentation and minor gotchas in Buffer

  puellanivis

  committed
  ae26d72

  Copy full SHA for ae26d72

• encoding: it is no longer intended that Buffer/RawPacket would be pooled, the byte slices should be

  puellanivis

  committed
  caecc84

  Copy full SHA for caecc84

• encoding: address further godoc concerns

  puellanivis

  committed
  716c28c

  Copy full SHA for 716c28c

• encoding: Status should also implement Error

  puellanivis

  committed
  3f02a54

  Copy full SHA for 3f02a54

• encoding: prefer ReadDir-style names

  puellanivis

  committed
  8b9e151

  Copy full SHA for 8b9e151

• encoding: MarshalPacket shall take a buffer hint now

  puellanivis

  committed
  fcaacbb

  Copy full SHA for fcaacbb

• encoding: move length const to exported value, I don't expect many to use such low limits.

  puellanivis

  committed
  05ef673

  Copy full SHA for 05ef673

Commits on Mar 24, 2021

• encoding: prevent duplicate extended packet type registrations

  puellanivis

  committed
  443b3a1

  Copy full SHA for 443b3a1

• openssh extensions: do not auto-register extended packet types

  puellanivis

  committed
  c496ef9

  Copy full SHA for c496ef9

• encoding: address slice alias concerns with documentation, and/or cloning

  puellanivis

  committed
  47ea397

  Copy full SHA for 47ea397

Commits on Mar 25, 2021

• encoding: use cap(b), only reallocate for cap(b) < 4, name magic constant

  puellanivis

  committed
  dcebc58

  Copy full SHA for dcebc58

Commits on Apr 20, 2021

• move to internal/ until we finalize the package

  puellanivis

  committed
  0e87b41

  Copy full SHA for 0e87b41