request server: fix handles leak in error case #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For open/opendir requests we create a new handle and close it when the client sends an SSH_FXP_CLOSE but if we return an error the client will never send the close packet so we have to close the handle ourselves
puellanivis
approved these changes
Nov 16, 2020
|
@puellanivis thank you for approving. What do you think about #392? After fixing the open connection tracking in this pull request #392 allows to return the correct exit status to the clients |
drakkan
added a commit
to drakkan/sftpgo
that referenced
this pull request
Nov 16, 2020
Include this patch: pkg/sftp#393 to avoid request accumulation (no underlying fd) if we return an error. Before this patch the accumulated requests are released only when the client disconnects. We use our fork for now to include pkg/sftp#392 too
drakkan
added a commit
to drakkan/sftpgo
that referenced
this pull request
Nov 18, 2020
These patches are now merged upstream: pkg/sftp#392 pkg/sftp#393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For open/opendir requests we create a new handle and close it
when the client sends an SSH_FXP_CLOSE but if we return an error the
client will never send the close packet so we have to close the handle
ourselves.
You can easily see the bug running the modified test cases without the patch.
The open handles will be closed when the client closes the whole connection, but if we have a client connected for a long time we accumulate handles every time we return an error for open/opendir.
This bug is more evident after applying #392 since the
EOFwill be converted toErrUnexpectedEOFif open requests are found when the client disconnects