Refactor implementation for (skipping) validation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
While reviewing IAMconsortium#532, I noticed that there was still a duplication of effort - first computing the aggregate values, then appending, then (optionally, true by default) again computing the aggregate values for the consistency evaluation.
This PR implements a more efficient approach: first compute the aggregate values, split them into two groups (already existing vs. new data), (optionally) perform the validation on existing data, then append the new data.
To do this efficiently, I moved the
comparefeature into a separate submodule and made it compatible with receiving a pd.Series directly.Also, I moved the test data for the recursive aggregation feature into conftest.py to remove duplicate code, and I added an explicit assertion that calling the recursive aggregation with inconsistent data raises an error.