Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call pjmedia_srtp_deinit_lib() when srtp_init() fail #3719

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Call pjmedia_srtp_deinit_lib() when srtp_init() fail #3719

merged 1 commit into from
Oct 2, 2023

Conversation

trengginas
Copy link
Member

This is to fix #3715.
Consider the scenario:

  1. Start PJSIP using pjsua_create() + pjsua_init().
  2. Failure in srtp_init().
  3. Handle the error and call pjsua_destroy().
  4. Re-init by calling pjsua_create() + pjsua_init()
  5. srtp_init() will fail with unsupported parameter [status=259801]

@trengginas trengginas added this to the release-2.14 milestone Sep 27, 2023
@trengginas trengginas self-assigned this Sep 27, 2023
@trengginas trengginas merged commit 2c1207c into master Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sauwming sauwming sauwming approved these changes

@nanangizz nanangizz nanangizz approved these changes

Assignees

@trengginas trengginas

Labels
component: pjmedia
Projects
None yet
Milestone
release-2.14
Development

Successfully merging this pull request may close these issues.

pjmedia_srtp_deinit_lib is not called if srtp_init fails
3 participants
@trengginas @sauwming @nanangizz