Skip to content

Commit

Permalink
Fixed issue with SDP version when reoffer is rejected (#4289)
Browse files Browse the repository at this point in the history
  • Loading branch information
sauwming authored Feb 6, 2025
1 parent 0252152 commit 99b4d1e
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions pjmedia/src/pjmedia/sdp_neg.c
Original file line number Diff line number Diff line change
Expand Up @@ -1940,15 +1940,18 @@ PJ_DEF(pj_status_t) pjmedia_sdp_neg_cancel_offer(pjmedia_sdp_neg *neg)
neg->state == PJMEDIA_SDP_NEG_STATE_REMOTE_OFFER,
PJMEDIA_SDPNEG_EINSTATE);

// No longer needed after #3322.
if (0 && neg->state == PJMEDIA_SDP_NEG_STATE_LOCAL_OFFER &&
if (neg->state == PJMEDIA_SDP_NEG_STATE_LOCAL_OFFER &&
neg->active_local_sdp)
{
/* Increment next version number. This happens if for example
* the reinvite offer is rejected by 488. If we don't increment
* the version here, the next offer will have the same version.
*/
neg->active_local_sdp->origin.version++;
// No longer needed after #3322.
// neg->active_local_sdp->origin.version++;

/* Revert last sent SDP. */
neg->last_sent = neg->active_local_sdp;
}

/* Revert back initial SDP */
Expand Down

0 comments on commit 99b4d1e

Please sign in to comment.