GHC 9.2.5 Support #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the bare minimum dependencies to get Byline to compile on 9.2.5 (locally and CI) - Added 9.2.5 to the test matrix - Updated deprecated GitHub actions so the CI won't break in the future - Fixed an example that was failing the linter - Updated copyright notice to 2023, and bumped version to 1.2.0 (as per PVP)
Closed
pjones
reviewed
Jan 20, 2023
|
If you change the version number to 1.1.2, I'll merge, update the Nix files and the change log, then push to Hackage. Thank you very much! |
|
Could you let the pipeline run before merging (if this is not required in the first place)? I know it's a trivial change, but I'd like to be sure everything still works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces support for GHC 9.2.5, the penultimate stable release of GHC.
I could not support GHC 9.4.4; Relude does not support it yet.
Summary of changes:
I noticed that the previous dependency update changed some Nix files.
I have not worked with Nix before, so if anything needs to be run/updated in that regard, could you point me in the right direction?