Add scalafmt GitHub action #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that even though the project has scalafmt added, its not being checked and hence the codebase is currently out of sync with the formatter.
This PR adds the scalafmt github action and also applies
scalafmtso the whole codebase is formatted.@pjfanning I would merge this PR with "Rebase + merge" in order to not lose the "Apply scalafmt" commit so it can be added to a
.git-blame-ignore-revsfile which I will do in a future PR. Also once merged you can add scalafmt github action to the github branch check so we don't accidentally merge unformatted code again.