Only enable inliner in CI by default #13
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d7c57e to
17d4718
Compare
17d4718 to
8633e72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming that we go ahead with https://lists.apache.org/thread/yvhjz1l523kwpbybnjssn0d4kl6dgl1s, this PR makes it so that by default the Scala 2 inliner is disabled locally but is enabled by default in CI. Due to this change in behaviour,
pekko.no.inlinehas been flipped topekko.inlinesince you now have to explicitly enable it. If for some reason we want to disable it in CI we can still set thepekkoInlineEnabledmanually to false.The logging has also been updated to reflect this, will different log messages depending on whether its been enabled in CI or with the system property.
PR is in draft until we agree to go ahead with building + publishing artifacts in CI to Apache staging