Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Demo #85

Merged
merged 7 commits into from
Oct 24, 2017
Merged

Refactor Demo #85

merged 7 commits into from
Oct 24, 2017

Conversation

bigtimebuddy
Copy link
Member

Replaces #81

This uses Rollup to build the demo project in tools/demo.

@bigtimebuddy bigtimebuddy mentioned this pull request Oct 24, 2017
@finscn
Copy link
Contributor

finscn commented Oct 24, 2017

I can't wait it.

@finscn
Copy link
Contributor

finscn commented Oct 24, 2017

Please don't resize bg sprite when window resize.
If do that users will can't know If "the bg resize effect" is filter's effect.
We could give it a big size(big enough) like this :

    bg.width = window.screen.availWidth;
    bg.height = window.screen.availHeight;

@bigtimebuddy
Copy link
Member Author

I’m not sure I agree with your concern about the background sprite. What about a proportional scale? So it maintains the same aspect ratio?

@finscn
Copy link
Contributor

finscn commented Oct 24, 2017

The proportional scale is better than current setting.
But if only scale bg and don't scale the fishes , it'll puzzle somebody still, e.g. Me.

@bigtimebuddy bigtimebuddy merged commit 247cfea into master Oct 24, 2017
@bigtimebuddy bigtimebuddy deleted the demo-refactor branch October 24, 2017 18:13
@bigtimebuddy bigtimebuddy restored the demo-refactor branch October 24, 2017 18:30
@bigtimebuddy bigtimebuddy deleted the demo-refactor branch February 4, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants