This repository has been archived by the owner on Jan 2, 2020. It is now read-only.
[#971] Add backup account confirmation page #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaissiqueira
suggested changes
Mar 15, 2017
| @@ -39,16 +40,23 @@ export class BackupEmail extends React.Component { | |||
| }); | |||
| } | |||
|
|
|||
| submitHandler = (event) => { | |||
| event.preventDefault(); | |||
| if (typeof this.props.onSubmit === 'function') { | |||
There was a problem hiding this comment.
Is this if necessary if we define that onSubmit is required (as you said it was required in the propTypes? I think we should avoid it.
| @@ -23,6 +24,15 @@ describe('BackupEmail', () => { | |||
| expect(page.find('SubmitButton').props().buttonText).toEqual('backup-account.backup-email.button'); | |||
| }); | |||
|
|
|||
| it('form submit should call parameter custom submit', () => { | |||
There was a problem hiding this comment.
Messages for tests should always start with a verb, since the syntax is: "BackupEmail calls...". Mocha follows the rule of describe(<ComponentName>), context(<Situation>), it(<action>).
| const event = { preventDefault() {} }; | ||
| page = shallow(<BackupEmail t={mockTranslations} onSubmit={mockOnSubmit} />); | ||
|
|
||
| page.instance().submitHandler(event); |
There was a problem hiding this comment.
Here, we could simulate a form submit to test that onSubmit was called.
backupEmail.find('form').simulate('submit', { preventDefault: () => {} });
expect(mockOnSubmit).toHaveBeenCalled();
| expect(page.find('a').text()).toEqual('backup-account.confirmation.retry-button'); | ||
| }); | ||
|
|
||
| it('retry button redirects to backup account', () => { |
| pageInstance = page.instance(); | ||
| }); | ||
|
|
||
| it('verify initial state', () => { |
| it('changes state', () => { | ||
| pageInstance.saveBackupEmail(); | ||
| expect(pageInstance.state.status).toEqual('success'); | ||
| }); |
There was a problem hiding this comment.
There is no test for checking if we are rendering Confirmation or BackupEmail component. 😢
|
@thaissiqueira and @anikarni As we talked, we fixed the issues in the confirmation.spec.js and page.spec.js |
anikarni
approved these changes
Mar 16, 2017
1103ec9 to
a36902d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still have to do the css for the confirmation page.