Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider making Changes file more parser friendly #66

Closed
luzpaz opened this issue Jan 10, 2024 · 8 comments · Fixed by #73
Closed

Please consider making Changes file more parser friendly #66

luzpaz opened this issue Jan 10, 2024 · 8 comments · Fixed by #73

Comments

@luzpaz
Copy link
Contributor

luzpaz commented Jan 10, 2024

At the time of this ticket the Changes file has non-uniform patterns to parse

Screenshot_20240110_151146

Would you consider following recommendations from https://keepachangelog.com or at least a minimal form of it.

Perhaps putting the date and version on the same line at least ?

@prigaux
Copy link
Collaborator

prigaux commented Jan 10, 2024

Hi. Why not. But there are already git tags. Could you precise why you need parsing the Changes?

@luzpaz
Copy link
Contributor Author

luzpaz commented Jan 10, 2024

Sure, see http://freshcode.club/submit/hexedit

Screenshot_20240110_180251

@luzpaz
Copy link
Contributor Author

luzpaz commented Nov 15, 2024

soft bump

@prigaux
Copy link
Collaborator

prigaux commented Nov 16, 2024

Sorry. Could you make a pull request reformatting the existing "Changes" file? I'll make sure the follow the chosen pattern afterwards.

@luzpaz
Copy link
Contributor Author

luzpaz commented Nov 20, 2024

Would you be OK with the following formatting style?

## [Unreleased] (date)
- 

## 1.6 (3/2022)
- configure script must error-out when (n)curses isn't found
- Move SIGWINCH handling from handler to NCURSES 
- Make configure.ac compliant with autoconf >= 2.70
- Check that malloc did not return NULL
- Fix a possible memory leak in findFile()
- Prevent division by zero on empty files.

## 1.5 (8/2020)
- Fix searching very long string
- Keep status of firstTime beween calls. (#35)
- man page: use simple double quotes (instead of weird ```xxx''')
- Properly handle off_t on non-lfs 32 bit systems.
- Fixed compiler warnings.
- Do not allow negative line length. (#34)
- fix overflow on excessively long escape sequence. (#32)
- Ignore KEY_RESIZE in main loop. (#33)
- Show percentage of cursor relative to filesize.
- Bug copy & paste (#29)

@prigaux
Copy link
Collaborator

prigaux commented Nov 20, 2024

I'm not used to dates with single digit for the month. What about 03/2022 or 2022-03?

@luzpaz
Copy link
Contributor Author

luzpaz commented Nov 20, 2024

## [Unreleased] (date)
- 

## 1.6 (03/2022)
- configure script must error-out when (n)curses isn't found
- Move SIGWINCH handling from handler to NCURSES 
- Make configure.ac compliant with autoconf >= 2.70
- Check that malloc did not return NULL
- Fix a possible memory leak in findFile()
- Prevent division by zero on empty files.

## 1.5 (08/2020)
- Fix searching very long string
- Keep status of firstTime beween calls. (#35)
- man page: use simple double quotes (instead of weird ```xxx''')
- Properly handle off_t on non-lfs 32 bit systems.
- Fixed compiler warnings.
- Do not allow negative line length. (#34)
- fix overflow on excessively long escape sequence. (#32)
- Ignore KEY_RESIZE in main loop. (#33)
- Show percentage of cursor relative to filesize.
- Bug copy & paste (#29)

@prigaux
Copy link
Collaborator

prigaux commented Nov 20, 2024

Go for it!
Thanks.

luzpaz added a commit to luzpaz/hexedit that referenced this issue Nov 20, 2024
prigaux pushed a commit that referenced this issue Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants