Update luogu.ts #21
Closed
Update luogu.ts #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxh06
requested changes
Jun 11, 2024
| export const judgementUrl = "https://www.luogu.com.cn/judgement"; | ||
| export const judgementUrl = "https://www.luogu.com/judgement"; |
There was a problem hiding this comment.
https://www.luogu.com/judgement 能正常访问吗？
| url.hostname === "www.luogu.com.cn" && isHTTPorHTTPS(url); | ||
| url.hostname === "www.luogu.com" && isHTTPorHTTPS(url); |
weibohan07
requested changes
Jun 11, 2024
There was a problem hiding this comment.
The changes you made is just simply replace all legacy luogu domains into new domains in our viewer. It's not hard to guess why you haven't also changed these domains in our archive module. The only possible reason I guess is that you are completely unfamiliar to our project. Thus I suggest you carefully read throughout our codes, and then you may pr again.
|
Fixed in #22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19
#20