Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RandomAccessBinaryCollection #30

Merged
merged 5 commits into from
Feb 28, 2022
Merged

Conversation

elshize
Copy link
Member

@elshize elshize commented Feb 26, 2022

RandomAccessBinaryCollection is a wrapper over BinaryCollection that
collects sequence offsets at construction time to allow for random
access.

@elshize elshize self-assigned this Feb 26, 2022
@elshize elshize requested a review from JMMackenzie February 26, 2022 02:15
RandomAccessBinaryCollection is a wrapper over BinaryCollection that
collects sequence offsets at construction time to allow for random
access.
@elshize elshize force-pushed the binary-coll-rand-access branch 2 times, most recently from e769f52 to 55ed983 Compare February 26, 2022 02:58
@elshize elshize force-pushed the binary-coll-rand-access branch from 55ed983 to 631cb2f Compare February 26, 2022 03:09
Copy link
Member

@JMMackenzie JMMackenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, looks good to me.

@elshize elshize merged commit ec1a710 into master Feb 28, 2022
@elshize elshize deleted the binary-coll-rand-access branch February 28, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants