Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactoring + tests #27

Merged
merged 1 commit into from
May 10, 2021
Merged

Small refactoring + tests #27

merged 1 commit into from
May 10, 2021

Conversation

elshize
Copy link
Member

@elshize elshize commented Apr 16, 2021

No description provided.

@elshize elshize self-assigned this Apr 16, 2021
@elshize elshize requested a review from JMMackenzie April 16, 2021 01:02
@elshize
Copy link
Member Author

elshize commented May 9, 2021

@JMMackenzie just reminding

JMMackenzie
JMMackenzie approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@JMMackenzie JMMackenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed these. Looks good to me!

@elshize elshize merged commit f61a341 into master May 10, 2021
@elshize elshize deleted the read-header branch May 10, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMMackenzie JMMackenzie JMMackenzie approved these changes

Assignees

@elshize elshize

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elshize @JMMackenzie