-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Menu Button Visibility #252
Fix Menu Button Visibility #252
Conversation
new location for menu button next to profile button
Do you still have the team workspace button on the left side? If so, I would still prefer to put the menu there. |
the team workspace button is still on the left side. The improvement moves the export button to the top right, alongside the profile and share buttons. This does solve the issue of the menu disappearing caused by some extensions. I noticed that enabling certain scripts can still cause the menu to disappear, but it’s not a major problem. |
Thanks for the contribution. But I still want to keep it in the same place. We can work on fixing the disappearing issue. I will merge the PR if we can't find or fix the problem. |
Update: |
Thanks for feedback 👍. An additional observation is that the menu button
in my PR didn't survive switching from desktop to mobile to desktop view.
Op do 5 sep 2024 om 19:11 schreef kgsjtl ***@***.***>:
… Thanks for the contribution. But I still want to keep it in the same
place. We can work on fixing the disappearing issue. I will merge the PR if
we can't find or fix the problem.
Update:
The menu disappeared again today. I’m not sure what happened, but the only
thing I’m certain of is that it conflicts with some scripts or
extensions—sometimes with extensions, sometimes with scripts. The most
challenging part is that it doesn’t conflict with any specific extension or
script.
—
Reply to this email directly, view it on GitHub
<#252 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKTLWPE62XOE5I5G3VERKVTZVCGC3AVCNFSM6AAAAABNQSKGMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSGI2DIOBTGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Latest version restores the menu button visibillity provided that another user script doesn't break it. |
This pull request fixes the issue of the main menu button disappearing since ChatGPT moved the profile button to a new location. This PR implements a robust solution for relocating the menu button to the profile button
div
.Changes Made:
div
. This visually groups it with the profile button.injectMenu()
function utilizessetInterval
to actively check if the menu button already exists in the profile buttondiv
. If not, it injects it. ThesetInterval
loop is immediately stopped after successful injection to minimize unnecessary checks and improve performance.Testing:
Benefits:
setInterval
termination, reduces unnecessary DOM manipulation for better performance.Screenshot:
Closing Issues
This PR closes issue #251.