Skip to content

Commit

Permalink
Upgrade the puppeteer package to v22 and node 18 (#31)
Browse files Browse the repository at this point in the history
* chore(node): bumping Superset to Node 18 (apache#27198)

* upgrade the puppeteer package to v22

---------

Co-authored-by: Evan Rusackas <evan@preset.io>
  • Loading branch information
2 people authored and kgopal492 committed Jan 27, 2025
1 parent 4a4dd7d commit c2ab698
Show file tree
Hide file tree
Showing 2 changed files with 680 additions and 720 deletions.
20 changes: 15 additions & 5 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ x-superset-user: &superset-user root
x-superset-depends-on: &superset-depends-on
- db
- redis
x-superset-volumes: &superset-volumes
# /app/pythonpath_docker will be appended to the PYTHONPATH in the final container
x-superset-volumes:
&superset-volumes # /app/pythonpath_docker will be appended to the PYTHONPATH in the final container
- ./docker:/app/docker
- ./superset:/app/superset
- ./superset-frontend:/app/superset-frontend
Expand Down Expand Up @@ -151,7 +151,9 @@ services:
environment:
# set this to false if you have perf issues running the npm i; npm run dev in-docker
# if you do so, you have to run this manually on the host, which should perform better!
SCARF_ANALYTICS: "${SCARF_ANALYTICS:-}"
BUILD_SUPERSET_FRONTEND_IN_DOCKER: ${BUILD_SUPERSET_FRONTEND_IN_DOCKER:-true}
SCARF_ANALYTICS: "${SCARF_ANALYTICS}"
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${BUILD_SUPERSET_FRONTEND_IN_DOCKER:-false}
container_name: superset_node
command: ["/app/docker/docker-frontend.sh"]
env_file:
Expand Down Expand Up @@ -181,7 +183,11 @@ services:
extra_hosts:
- "host.docker.internal:host-gateway"
healthcheck:
test: ["CMD-SHELL", "celery -A superset.tasks.celery_app:app inspect ping -d celery@$$HOSTNAME"]
test:
[
"CMD-SHELL",
"celery -A superset.tasks.celery_app:app inspect ping -d celery@$$HOSTNAME",
]
# Bump memory limit if processing selenium / thumbnails on superset-worker
# mem_limit: 2038m
# mem_reservation: 128M
Expand Down Expand Up @@ -227,7 +233,11 @@ services:
user: *superset-user
volumes: *superset-volumes
healthcheck:
test: ["CMD-SHELL", "celery inspect ping -A superset.tasks.celery_app:app -d celery@$$HOSTNAME"]
test:
[
"CMD-SHELL",
"celery inspect ping -A superset.tasks.celery_app:app -d celery@$$HOSTNAME",
]

volumes:
superset_home:
Expand Down
Loading

0 comments on commit c2ab698

Please sign in to comment.