-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Carthage for watchOS, fix macOS min deployment target version #269
Conversation
…get, which should be macOS 10.8 && tvOS 9.0
@dreampiggy Thanks for putting this up! I'm going to merge and put up another PR to update Carthage to use PINOperation 1.2. With regards to the checkins, I'm not 1000% convinced it's the best course of action, but the intention is to make it so the repo can be built as is without fetching dependencies. |
Finally...This get merged :) |
Ah! I forgot the real reason we include checkouts is because the Xcode projects depend on them: #280 |
You can just use This is standard what package manager should do, like CocoaPods (You need to run |
@garrettmoon #279. Please check this to fix current watchOS Carthage issues. |
Dependent pinterest/PINOperation#31
This close #268
CC: @garrettmoon
To make Carthage works (because you use ~>
1.1.0
dependency):You should firstly merge that PINOperation, release a new version.
Then merge this PR, release a new version.
Note: I also found that
Carthage/Checkouts
is not in Git Ignore files, does this have anything useful ? Why not ignore those files because when you runcarthage update
, it will be override and cause massive git diffs.