Add option.stackAdjustment #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 18, 2023 18:53
This allows users to customize where in the stack to pull info from, and its main audience is people who have written wrappers around pino. The default stack level that pino-caller uses is wrong for these people, but a small constant adjustment (usually of 1) is enough to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new option
stackAdjustmentto pino-caller to help people fine tune which stack frame they want to use for logging purposes. It's needed by people who have wrapped pino, because the default behavior gets the wrong frame, but if a small constant adjustment could be applied, the right frame could be found.This should address the concerns in issue #90.