Update default behavior for PATCH ADDs with filter #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the 3.2.0 release, we updated the SCIM SDK so that add operations with a filter could target existing values on the resource via a configurable property on the PatchOperation class. This is more appropriate than the previous behavior, but was not made the default. This commit updates the SDK to target existing values by default. The project version has been updated to 4.0.0-SNAPSHOT signify this change. Reviewer: vyhhuang Reviewer: dougbulkley JiraIssue: DS-49617
kqarryzada
commented
Jan 30, 2025
| @@ -107,9 +111,6 @@ public void testBasic() throws Exception | |||
| PatchRequest request; | |||
| UserResource resource = new UserResource(); | |||
|
|
|||
| // Unset the property to use the new behavior. | |||
| PatchOperation.APPEND_NEW_PATCH_VALUES_PROPERTY = false; | |||
There was a problem hiding this comment.
I removed this to make sure that testBasic() inherits the default value provided by the SDK.
dougbulkley
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 3.2.0 release, we updated the SCIM SDK so that add operations with a filter could target existing values on the resource via a configurable property on the PatchOperation class. This is more appropriate than the previous behavior, but was not made the default.
This commit updates the SDK to target existing values by default. The project version has been updated to 4.0.0-SNAPSHOT signify this change.
Reviewer: vyhhuang
Reviewer: dougbulkley
JiraIssue: DS-49617