Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix duplicate range in RowIDAllocator #2156

Merged
merged 5 commits into from
Nov 12, 2021
Merged

fix duplicate range in RowIDAllocator #2156

merged 5 commits into from
Nov 12, 2021

Conversation

humengyu2012
Copy link
Contributor

@humengyu2012 humengyu2012 commented Nov 7, 2021 •
edited
Loading

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@humengyu2012 humengyu2012 mentioned this pull request Nov 7, 2021
Closed
@humengyu2012
Copy link
Contributor Author

/run-all-tests

sunxiaoguang
sunxiaoguang reviewed Nov 7, 2021
View reviewed changes
Copy link
Collaborator

@sunxiaoguang sunxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REST LGTM

@sunxiaoguang
Copy link
Collaborator

/run-test_integration-test

@sunxiaoguang
Copy link
Collaborator

sunxiaoguang commented Nov 7, 2021 •
edited
Loading

image

Old value is not read in the same transaction.

@humengyu2012
Copy link
Contributor Author

/run-test_integration-test

@sunxiaoguang
Copy link
Collaborator

/run-all-tests

birdstorm
birdstorm approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm birdstorm added needs-cherry-pick-2.3 needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4 labels Nov 10, 2021
@sunxiaoguang
Copy link
Collaborator

/merge

@sunxiaoguang sunxiaoguang merged commit b7729f3 into pingcap:master Nov 12, 2021
@ti-srebot ti-srebot mentioned this pull request Nov 12, 2021
Merged
sunxiaoguang pushed a commit that referenced this pull request Nov 30, 2021
@ti-srebot @humengyu2012
fix duplicate range in RowIDAllocator (#2156) (#2159)
d8d3d3a 
* fix duplicate range in RowIDAllocator

* code style

* optimization

* optimization

* startTs use snapshot timestamp

Co-authored-by: humengyu <hellohumengyu@gmail.com>
@xuanyu66
Copy link
Collaborator

/run-cherry-picker

@ti-srebot
Copy link
Collaborator

cherry pick to release-2.3 failed

@ti-srebot ti-srebot mentioned this pull request Jan 18, 2022
Merged
sunxiaoguang added a commit that referenced this pull request Jan 21, 2022
@ti-srebot @humengyu2012 @sunxiaoguang
fix duplicate range in RowIDAllocator (#2156) (#2208)
feb4781 
* fix duplicate range in RowIDAllocator

* code style

* optimization

* optimization

* startTs use snapshot timestamp

Co-authored-by: humengyu <hellohumengyu@gmail.com>
Co-authored-by: Xiaoguang Sun <sunxiaoguang@users.noreply.github.com>
@shiyuhang0 shiyuhang0 mentioned this pull request Jan 26, 2022
Open
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@humengyu2012
fix duplicate range in RowIDAllocator (pingcap#2156)
d0de09c 
* fix duplicate range in RowIDAllocator

* code style

* optimization

* optimization

* startTs use snapshot timestamp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunxiaoguang sunxiaoguang sunxiaoguang approved these changes

@birdstorm birdstorm birdstorm approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@humengyu2012 @CLAassistant @sunxiaoguang @xuanyu66 @ti-srebot @birdstorm