Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*(ticdc): do not print password in cdc log #9691

Merged
merged 3 commits into from
Sep 11, 2023
Merged

*(ticdc): do not print password in cdc log #9691

merged 3 commits into from
Sep 11, 2023

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Sep 6, 2023

What problem does this PR solve?

Issue Number: close #9690

What is changed and how it works?

  1. mask password
  2. do not print configurations

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2023
@sdojjy sdojjy added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Sep 6, 2023
@sdojjy
Copy link
Member Author

sdojjy commented Sep 6, 2023

/retest-required

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2023
@sdojjy
Merge remote-tracking branch 'upstream/master' into donot-print-passw…
58932b4 
…rord-in-cdc-log

# Conflicts:
#	pkg/config/replica_config.go
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 7, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 8, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-07 11:31:48.625942097 +0000 UTC m=+2617873.174958065: ☑️ agreed by asddongmen.
  • 2023-09-08 06:13:21.526804452 +0000 UTC m=+2685166.075820436: ☑️ agreed by nongfushanquan.

@sdojjy
Copy link
Member Author

sdojjy commented Sep 11, 2023

/test dm-integration-test

@sdojjy
Copy link
Member Author

sdojjy commented Sep 11, 2023

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented Sep 11, 2023

/test cdc-integration-mysql-test

@sdojjy
Copy link
Member Author

sdojjy commented Sep 11, 2023

/test dm-integration-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023

@sdojjy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dm-integration-test 58932b4 link true /test dm-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nongfushanquan
Copy link
Contributor

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 6ea9a41 into pingcap:master Sep 11, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9725.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 11, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 11, 2023
@sdojjy @ti-chi-bot
This is an automated cherry-pick of pingcap#9691
4f8aed2 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 11, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9727.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 11, 2023
@sdojjy @ti-chi-bot
This is an automated cherry-pick of pingcap#9691
bab0ddc 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@sdojjy sdojjy deleted the donot-print-passwrord-in-cdc-log branch September 11, 2023 10:52
ti-chi-bot bot pushed a commit that referenced this pull request Sep 11, 2023
@ti-chi-bot
*(ticdc): do not print password in cdc log (#9691) (#9725)
b49ddbe 
close #9690
ti-chi-bot bot pushed a commit that referenced this pull request Sep 14, 2023
@ti-chi-bot
*(ticdc): do not print password in cdc log (#9691) (#9727)
b9dcc64 
close #9690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@nongfushanquan nongfushanquan nongfushanquan approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

do not print password in cdc log
4 participants
@sdojjy @nongfushanquan @ti-chi-bot @asddongmen