-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changefeed (ticdc): remove error state and add pending, warning state (#9358) #9626
changefeed (ticdc): remove error state and add pending, warning state (#9358) #9626
Conversation
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
955063e
to
8bb611a
Compare
/retest |
/test all |
/test all |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test dm-integration-test |
1 similar comment
/test dm-integration-test |
This is an cherry-pick of #9358 #9687 #9593
What problem does this PR solve?
Issue Number: ref #9273, ref #9697, ref #9594
What is changed and how it works?
After this PR, the error status of changefeed will be removed, and the warning status will be added.
The changefeed status transition is shown in the following figure.
stopped
state.normal
state.warning
state. Changefeed automatically retries in thewarning
state.CheckpointTs
advances beyond theCheckpointTs
when the error occurred, the changefeed enters thenormal
state.failed
state. After entering thefailed
state, the changefeed will block the GC of the upstream TiDB cluster. The default blocking time isgc-ttl
. Users can manually recover the changefeed within thegc-ttl
time.failed
state.TargetTs
.gc-ttl
, it cannot be recovered.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note