Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeed (ticdc): remove error state and add pending, warning state (#9358) #9626

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 22, 2023

This is an cherry-pick of #9358 #9687 #9593

What problem does this PR solve?

Issue Number: ref #9273, ref #9697, ref #9594

What is changed and how it works?

After this PR, the error status of changefeed will be removed, and the warning status will be added.
The changefeed status transition is shown in the following figure.

image

  1. The user pauses changefeed, and changefeed enters the stopped state.
  2. The user resumes changefeed, and changefeed returns to the normal state.
  3. Changefeed encounters an error and enters the warning state. Changefeed automatically retries in the warning state.
  4. If the changefeed retry is successful and the CheckpointTs advances beyond the CheckpointTs when the error occurred, the changefeed enters the normal state.
  5. If the changefeed error retry exceeds the maximum retry time limit, it enters the failed state. After entering the failed state, the changefeed will block the GC of the upstream TiDB cluster. The default blocking time is gc-ttl. Users can manually recover the changefeed within the gc-ttl time.
  6. If the changefeed encounters an unrecoverable error during the running process, it directly enters the failed state.
  7. The changefeed is complete, and the its progress has reached the preset TargetTs.
  8. If the changefeed is in the stopped state for a time exceeding the duration specified by gc-ttl, it cannot be recovered.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Aug 22, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Aug 22, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 22, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@asddongmen asddongmen closed this Sep 27, 2023
@asddongmen asddongmen force-pushed the cherry-pick-9358-to-release-7.1 branch from 955063e to 8bb611a Compare September 27, 2023 02:01
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 27, 2023
@asddongmen asddongmen reopened this Sep 27, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2023
@nongfushanquan
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/test all

@asddongmen asddongmen removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2023
@asddongmen
Copy link
Contributor

/test all

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 27, 2023
@nongfushanquan
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/test dm-integration-test

1 similar comment
@asddongmen
Copy link
Contributor

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot merged commit c61ce18 into pingcap:release-7.1 Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants