Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiv2(ticdc): delete changefeed #8020

Merged
merged 12 commits into from
Jan 10, 2023
Merged

apiv2(ticdc): delete changefeed #8020

merged 12 commits into from
Jan 10, 2023

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Jan 5, 2023 •
edited by asddongmen
Loading

What problem does this PR solve?

Issue Number: ref #8019

What is changed and how it works?

  1. delete changefeeed open api v2
  2. cdc cli use open api v2 to delete the changefeed

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

 `None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 5, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 5, 2023
@sdojjy sdojjy mentioned this pull request Jan 5, 2023
Closed
17 tasks
@sdojjy
Copy link
Member Author

sdojjy commented Jan 5, 2023

/run-integration-tests

@sdojjy sdojjy changed the title apiv2(ticdc): delete changefeed api v2 (WIP) apiv2(ticdc): delete changefeed api v2 Jan 5, 2023
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2023
@sdojjy sdojjy changed the title (WIP) apiv2(ticdc): delete changefeed api v2 apiv2(ticdc): delete changefeed api v2 Jan 9, 2023
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2023
@sdojjy sdojjy requested review from asddongmen and zhaoxinyu January 9, 2023 03:44
@sdojjy
Copy link
Member Author

sdojjy commented Jan 9, 2023

/run-all-tests

@sdojjy
Copy link
Member Author

sdojjy commented Jan 9, 2023

/run-verify-tests
/run-dm-integration-test

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 9, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 9, 2023
@overvenus overvenus changed the title apiv2(ticdc): delete changefeed api v2 apiv2(ticdc): delete changefeed Jan 10, 2023
@sdojjy
Copy link
Member Author

sdojjy commented Jan 10, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 177af69

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 10, 2023
@ti-chi-bot
Copy link
Member

@sdojjy: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sdojjy
Copy link
Member Author

sdojjy commented Jan 10, 2023

/run-integration-tests
/run-engine-integration-tests

@ti-chi-bot ti-chi-bot merged commit 0f7c2c3 into pingcap:master Jan 10, 2023
@sdojjy sdojjy deleted the delete-changefeed-open-api-v2 branch January 11, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@asddongmen asddongmen asddongmen approved these changes

@zhaoxinyu zhaoxinyu Awaiting requested review from zhaoxinyu

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdojjy @ti-chi-bot @3AceShowHand @asddongmen