Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo(ticdc): handle error correctly in redo manager #6366

Merged
merged 3 commits into from
Jul 21, 2022
Merged

redo(ticdc): handle error correctly in redo manager #6366

merged 3 commits into from
Jul 21, 2022

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Jul 20, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #6368

What is changed and how it works?

handle error correctly in redo manager

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nongfushanquan
  • zhaoxinyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 20, 2022
@ti-chi-bot ti-chi-bot requested review from hicqu and zhaoxinyu July 20, 2022 09:17
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2022
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 21, 2022
@nongfushanquan
Copy link
Contributor

/cherry-pick release-6.1

@ti-chi-bot
Copy link
Member

@nongfushanquan: once the present PR merges, I will cherry-pick it on top of release-6.1 in the new PR and assign it to you.

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: da9a13f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2022
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jul 21, 2022
@ti-chi-bot
Copy link
Member

@CharlesCheung96: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@asddongmen
Copy link
Contributor

/merge

1 similar comment
@sdojjy
Copy link
Member

sdojjy commented Jul 21, 2022

/merge

@nongfushanquan
Copy link
Contributor

/run-integration-test
/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit c2bb3d8 into pingcap:master Jul 21, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 21, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6386.

@nongfushanquan nongfushanquan mentioned this pull request Jul 21, 2022
Closed
ti-chi-bot added a commit that referenced this pull request Jul 21, 2022
@ti-chi-bot
redo(ticdc): handle error correctly in redo manager (#6366) (#6386)
7ae9dca 
close #6368
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 21, 2022
Merged
ti-chi-bot added a commit that referenced this pull request Jul 21, 2022
@ti-chi-bot
redo(ticdc): handle error correctly in redo manager (#6366) (#6386) (#…
052c6e7 
…6414)

close #6368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoxinyu zhaoxinyu zhaoxinyu approved these changes

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@hicqu hicqu Awaiting requested review from hicqu

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error should be handled properly in redo Manager
7 participants
@CharlesCheung96 @ti-chi-bot @nongfushanquan @Rustin170506 @asddongmen @sdojjy @zhaoxinyu