Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(ticdc): use 1 minute kv retry time (#5499) #5530

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pkg/cmd/server/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,16 @@ func TestParseCfg(t *testing.T) {
},
PerTableMemoryQuota: 10 * 1024 * 1024, // 10M
KVClient: &config.KVClientConfig{
<<<<<<< HEAD
WorkerConcurrent: 8,
WorkerPoolSize: 0,
RegionScanLimit: 40,
=======
WorkerConcurrent: 8,
WorkerPoolSize: 0,
RegionScanLimit: 40,
RegionRetryDuration: config.TomlDuration(time.Minute),
>>>>>>> 4d48968a0 (config(ticdc): use 1 minute kv retry time (#5499))
},
Debug: &config.DebugConfig{
EnableTableActor: false,
Expand Down Expand Up @@ -454,9 +461,16 @@ cert-allowed-cn = ["dd","ee"]
},
PerTableMemoryQuota: 10 * 1024 * 1024, // 10M
KVClient: &config.KVClientConfig{
<<<<<<< HEAD
WorkerConcurrent: 8,
WorkerPoolSize: 0,
RegionScanLimit: 40,
=======
WorkerConcurrent: 8,
WorkerPoolSize: 0,
RegionScanLimit: 40,
RegionRetryDuration: config.TomlDuration(time.Minute),
>>>>>>> 4d48968a0 (config(ticdc): use 1 minute kv retry time (#5499))
},
Debug: &config.DebugConfig{
EnableTableActor: false,
Expand Down
5 changes: 5 additions & 0 deletions pkg/config/config_test_data.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,12 @@ const (
"kv-client": {
"worker-concurrent": 8,
"worker-pool-size": 0,
<<<<<<< HEAD
"region-scan-limit": 40
=======
"region-scan-limit": 40,
"region-retry-duration": 60000000000
>>>>>>> 4d48968a0 (config(ticdc): use 1 minute kv retry time (#5499))
},
"debug": {
"enable-table-actor": false,
Expand Down
6 changes: 6 additions & 0 deletions pkg/config/server_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,12 @@ var defaultServerConfig = &ServerConfig{
WorkerConcurrent: 8,
WorkerPoolSize: 0, // 0 will use NumCPU() * 2
RegionScanLimit: 40,
<<<<<<< HEAD
=======
// The default TiKV region election timeout is [10s, 20s],
// Use 1 minute to cover region leader missing.
RegionRetryDuration: TomlDuration(time.Minute),
>>>>>>> 4d48968a0 (config(ticdc): use 1 minute kv retry time (#5499))
},
Debug: &DebugConfig{
EnableTableActor: false,
Expand Down