-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syncer(dm) : fix default collation with upstream in create table statement (#3575) #3753
syncer(dm) : fix default collation with upstream in create table statement (#3575) #3753
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
/assign @nongfushanquan |
@ti-chi-bot: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this feature should be combined with a switch in configuration file, they will be introduced in v5.4.0 |
This is an automated cherry-pick of #3575
What problem does this PR solve?
fix https://github.com/pingcap/ticdc/issues/3420
in this case:
sql1:
create database if not exists test
sql2:
create database test CHARACTER SET=utf8mb4
sql3:
create table test.t1 (id int)
sql4:
create table test.t1 (id int) CHARSET=utf8mb4
if syncer send the same ddl to downstream tidb, database or table will has diffrent
collation
from upstream mysql, because the default collation is different between tidb and mysql.What is changed and how it works?
it will adjust collation when sync
create database
orcreate table
statement.for database, it will add
collation
by binlog query event and handle ddl like these:sql1:
create database if not exists test COLLATE = utf8mb4_general_ci
sql2:
create database test CHARACTER SET=utf8mb4 COLLATE = utf8mb4_general_ci
for table has no
charset
andcollation
, as we can not getcollation
from binlog, so there will have issue about timeliness, because dm can set start position at increment mode. so we will check and add warning log in dm.in this case, downstream db will use
collation
from database for table, so user can use dm sync dabase ddl sql, but if not, user should make sure dabase'scollation
is right if create dabase manually. so the ddl will be handled like that:sql3:
create table test.t1 (id int)
and warning logdetect create table risk which use implicit charset and collation
for table has
charset
but nocollation
, we will add default collation bySHOW CHARACTER SET
, so the dll will be handled like that:sql4:
create table test.t1 (id int) CHARSET=utf8mb4 COLLATE = utf8mb4_general_ci
Check List
Tests
Release note