Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ticdc kafka sink non-batch protocol performance #7353

Closed
Rustin170506 opened this issue Oct 13, 2022 · 0 comments · Fixed by #7351
Closed

Improve ticdc kafka sink non-batch protocol performance #7353

Rustin170506 opened this issue Oct 13, 2022 · 0 comments · Fixed by #7351
Labels
area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. type/enhancement The issue or PR belongs to an enhancement.

Comments

@Rustin170506
Copy link
Member

Is your feature request related to a problem?

In the current implementation we always save batches, but for some protocols it is not necessary.

tiflow/cdc/sinkv2/eventsink/mq/worker.go

Line 92 in 796d13f

func (w *worker) run(ctx context.Context) (retErr error) {

Describe the feature you'd like

Improve ticdc kafka sink non-batch protocol performance.

Describe alternatives you've considered

No response

Teachability, Documentation, Adoption, Migration Strategy

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sinkv2(ticdc): stop waiting for a batch for non-batched protocol Rustin170506/tiflow
1 participant
@Rustin170506