Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data race on blackhole sink FlushRowChangedEvents #6206

Closed
overvenus opened this issue Jul 7, 2022 · 1 comment
Closed

Data race on blackhole sink FlushRowChangedEvents #6206

overvenus opened this issue Jul 7, 2022 · 1 comment
Assignees
@asddongmen
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. severity/minor type/bug The issue is confirmed as a bug.

Comments

@overvenus
Copy link
Member

What did you do?

Just run integration tests

What did you expect to see?

No data race

What did you see instead?

Data race

WARNING: DATA RACE
Read at 0x00c002e93d68 by goroutine 298:
  github.com/pingcap/tiflow/cdc/sink.(*blackHoleSink).FlushRowChangedEvents.func1()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/sink/black_hole.go:63 +0x66

Previous write at 0x00c002e93d68 by goroutine 299:
  github.com/pingcap/tiflow/cdc/sink.(*blackHoleSink).FlushRowChangedEvents.func1()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/sink/black_hole.go:64 +0x7e
  github.com/pingcap/tiflow/cdc/sink/metrics.(*Statistics).RecordBatchExecution()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/sink/metrics/statistics.go:154 +0x5d

Details: stdout.log

Versions of the cluster

TiCDC version (execute cdc version):

master branch 2022/07/06
@overvenus overvenus added type/bug The issue is confirmed as a bug. area/ticdc Issues or PRs related to TiCDC. labels Jul 7, 2022
@asddongmen asddongmen self-assigned this Jul 7, 2022
@asddongmen asddongmen mentioned this issue Jul 7, 2022
Merged
@asddongmen asddongmen added the affects-6.1 This bug affects the 6.1.x(LTS) versions. label Jul 7, 2022
ti-chi-bot pushed a commit that referenced this issue Jul 8, 2022
@asddongmen
sink (ticdc): Fix a data race in black hole sink. (#6219)
a1da9b4 
close #5714, ref #6206
@ti-chi-bot ti-chi-bot mentioned this issue Jul 8, 2022
Merged
@asddongmen
Copy link
Contributor

fixed in #6219

ti-chi-bot added a commit that referenced this issue Jul 9, 2022
@ti-chi-bot
sink (ticdc): Fix a data race in black hole sink. (#6219) (#6229)
0ab92c0 
close #5714, ref #6206
@nongfushanquan nongfushanquan mentioned this issue Aug 29, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asddongmen asddongmen

Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@overvenus @asddongmen