Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify log style and zap field names #4239

Closed
overvenus opened this issue Jan 6, 2022 · 0 comments · Fixed by #4235
Closed

Unify log style and zap field names #4239

overvenus opened this issue Jan 6, 2022 · 0 comments · Fixed by #4235
Labels
area/ticdc Issues or PRs related to TiCDC. component/metrics-logging Metrics and logging component.

Comments

@overvenus
Copy link
Member

  • Prefer using "duration" for slow logs
  • Prefer using camelCase for zap field names
@overvenus overvenus added component/metrics-logging Metrics and logging component. area/ticdc Issues or PRs related to TiCDC. labels Jan 6, 2022
@overvenus overvenus mentioned this issue Jan 6, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Jan 6, 2022
@overvenus
cdc,pkg,tests(ticdc): unify cdc log style (#4235)
4f47b9e 
close #4239
overvenus added a commit to ti-chi-bot/tiflow that referenced this issue Jan 18, 2022
@overvenus
cdc,pkg,tests(ticdc): unify cdc log style (pingcap#4235)
18cfe11 
close pingcap#4239
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this issue Jan 20, 2022
@overvenus @zhaoxinyu
cdc,pkg,tests(ticdc): unify cdc log style (pingcap#4235)
a2194fb 
close pingcap#4239
overvenus added a commit to ti-chi-bot/tiflow that referenced this issue Jun 21, 2022
@overvenus
cdc,pkg,tests(ticdc): unify cdc log style (pingcap#4235)
e8cedf8 
close pingcap#4239

Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus added a commit to ti-chi-bot/tiflow that referenced this issue Jun 23, 2022
@overvenus
cdc,pkg,tests(ticdc): unify cdc log style (pingcap#4235)
c7b7732 
close pingcap#4239

Signed-off-by: Neil Shen <overvenus@gmail.com>
ti-chi-bot pushed a commit that referenced this issue Jun 23, 2022
@overvenus @ti-chi-bot
cdc,pkg,tests(ticdc): unify cdc log style (#4235)
cd49db6 
close #4239

Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/metrics-logging Metrics and logging component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cdc,pkg,tests(ticdc): unify cdc log style overvenus/ticdc
1 participant
@overvenus