Skip to content

Commit

Permalink
Merge branch 'bump-tidb' of github.com:okJiang/tiflow into bump-tidb
Browse files Browse the repository at this point in the history
  • Loading branch information
okJiang committed Nov 15, 2022
2 parents 10c3c92 + a0684fb commit 4529637
Show file tree
Hide file tree
Showing 27 changed files with 848 additions and 298 deletions.
13 changes: 7 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ FAIL_ON_STDOUT := awk '{ print } END { if (NR > 0) { exit 1 } }'

CURDIR := $(shell pwd)
path_to_add := $(addsuffix /bin,$(subst :,/bin:,$(GOPATH)))
export PATH := $(CURDIR)/bin:$(path_to_add):$(PATH)
export PATH := $(CURDIR)/bin:$(CURDIR)/tools/bin:$(path_to_add):$(PATH)

SHELL := /usr/bin/env bash

Expand Down Expand Up @@ -147,7 +147,7 @@ storage_consumer:
install:
go install ./...

unit_test: check_failpoint_ctl generate_mock generate-msgp-code generate-protobuf
unit_test: check_failpoint_ctl generate_mock go-generate generate-protobuf
mkdir -p "$(TEST_DIR)"
$(FAILPOINT_ENABLE)
@export log_level=error;\
Expand Down Expand Up @@ -233,7 +233,7 @@ clean_integration_test_containers: ## Clean MySQL and Kafka integration test con
integration_test_storage: check_third_party_binary
tests/integration_tests/run.sh storage "$(CASE)" "$(START_AT)"

fmt: tools/bin/gofumports tools/bin/shfmt tools/bin/gci generate_mock generate-msgp-code
fmt: tools/bin/gofumports tools/bin/shfmt tools/bin/gci generate_mock go-generate
@echo "run gci (format imports)"
tools/bin/gci write $(FILES) 2>&1 | $(FAIL_ON_STDOUT)
@echo "run gofumports"
Expand Down Expand Up @@ -272,9 +272,10 @@ ifneq ($(shell echo $(RELEASE_VERSION) | grep master),)
@./scripts/check-diff-line-width.sh
endif

generate-msgp-code: tools/bin/msgp
@echo "generate-msgp-code"
./scripts/generate-msgp-code.sh
go-generate: ## Run go generate on all packages.
go-generate: tools/bin/msgp tools/bin/stringer tools/bin/mockery
@echo "go generate"
@go generate ./...

generate-protobuf: ## Generate code from protobuf files.
generate-protobuf: tools/bin/protoc tools/bin/protoc-gen-gogofaster \
Expand Down
2 changes: 1 addition & 1 deletion cdc/processor/pipeline/sink.go
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ func (n *sinkNode) emitRowToSink(ctx context.Context, event *model.PolymorphicEv

emitRows := func(rows ...*model.RowChangedEvent) error {
if n.redoManager != nil && n.redoManager.Enabled() {
err := n.redoManager.EmitRowChangedEvents(ctx, n.tableID, rows...)
err := n.redoManager.EmitRowChangedEvents(ctx, n.tableID, nil, rows...)
if err != nil {
return err
}
Expand Down
Loading

0 comments on commit 4529637

Please sign in to comment.