Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for tidb/issues/49241 #8480

Merged
merged 11 commits into from
Dec 15, 2023
Merged

Add test for tidb/issues/49241 #8480

merged 11 commits into from
Dec 15, 2023

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Dec 7, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6233, close pingcap/tidb#49241,

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Dec 7, 2023
@Lloyd-Pottiger Lloyd-Pottiger mentioned this pull request Dec 7, 2023
Merged
13 tasks
CalvinNeo
CalvinNeo approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 7, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-triage-completed labels Dec 7, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/hold

till pingcap/tidb#49241 merged

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 7, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-07 06:39:29.944122169 +0000 UTC m=+1682398.609348357: ☑️ agreed by CalvinNeo.
  • 2023-12-07 09:49:50.547476117 +0000 UTC m=+1693819.212702309: ☑️ agreed by JaySon-Huang.

@Lloyd-Pottiger
add test
385d645 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
add test
2a062d6 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
refine
f034ef2 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
test cop/batchcop
41ab6d8 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
tidb_allow_batch_cop = 2
8da85e4 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
windtalker
windtalker approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Dec 13, 2023
Merged
Merged
@Lloyd-Pottiger
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/run-all-tests

ti-chi-bot bot and others added 2 commits December 14, 2023 06:22
@ti-chi-bot
Merge branch 'master' into add-test
cd5d9ea
@Lloyd-Pottiger
fix not database selected
0a0e019 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
Copy link
Contributor Author

/approve

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 14, 2023

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

  • Currently the CI jobs are not prow job style, we need it to notify Jenkins server to run them.
  • If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang, Lloyd-Pottiger, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,JaySon-Huang,Lloyd-Pottiger,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JaySon-Huang
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 14, 2023

@Lloyd-Pottiger: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JaySon-Huang
Copy link
Contributor

/hold

The tidb testing image does not contain the necessary commit

[2023/12/14 08:49:11.776 +00:00] [INFO] [printer.go:47] ["Welcome to TiDB."] ["Release Version"=v7.6.0-alpha] [Edition=Community] ["Git Commit Hash"=9633ca1fb4993c727dcdcc015d89a2afdea2e4bb] ["Git Branch"=heads/refs/tags/v7.6.0-alpha] ["UTC Build Time"="2023-12-13 11:44:52"] [GoVersion=go1.21.5] ["Race Enabled"=false] ["Check Table Before Drop"=false]

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2023
@JaySon-Huang
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2023
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit 90cb28d into pingcap:master Dec 15, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 15, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8531.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8532.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 15, 2023
Merged
12 tasks
@Lloyd-Pottiger Lloyd-Pottiger deleted the add-test branch December 15, 2023 06:27
ti-chi-bot bot pushed a commit that referenced this pull request Dec 15, 2023
@ti-chi-bot
Add test for tidb/issues/49241 (#8480) (#8531)
3d5c741 
ref #6233, close pingcap/tidb#49241
ti-chi-bot bot pushed a commit that referenced this pull request Dec 15, 2023
@ti-chi-bot
Add test for tidb/issues/49241 (#8480) (#8532)
701ec11 
ref #6233, close pingcap/tidb#49241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@windtalker windtalker windtalker approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cop Apply operator will not fill correlated column value in late materialization filter condition
5 participants
@Lloyd-Pottiger @JaySon-Huang @ti-chi-bot @windtalker @CalvinNeo